Add name component #20798
Merged
Add name component #20798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
added
the
team-confirmations-system
Update Lavamoat policies.
Builds ready [dd4f2a5]
Page Load Metrics (1960 ± 92 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20798 +/- ##
===========================================
+ Coverage 68.17% 68.24% +0.08%
===========================================
Files 998 1002 +4
Lines 39966 40130 +164
Branches 10686 10732 +46
===========================================
+ Hits 27243 27386 +143
- Misses 12723 12744 +21
☔ View full report in Codecov by Sentry. |
Builds ready [daf6902]
Page Load Metrics (1642 ± 72 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [cbe4188]
Page Load Metrics (1667 ± 44 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinistevam
previously approved these changes
Sep 14, 2023
Builds ready [5372d18]
Page Load Metrics (1707 ± 84 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinistevam
approved these changes
Sep 18, 2023
OGPoyraz
approved these changes
Sep 18, 2023
metamaskbot
added
the
release-11.3.0
|
🔥 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add the
Namecomponent to display a saved petname or a proposed name, for raw values such as Ethereum account addresses.Add the nested
NameDetailscomponent when theNamecomponent is clicked, which includes a modal containing a text field and dropdown of all available proposed names.Add the
FormComboFieldcomponent to provide a free entry text field with a dropdown of suggested options including both primary and secondary text.No functional usages yet, just the associated stories including documentation.
Screenshots
Name
NameDetails
FormComboField
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.